chore: remove mcode models and references #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #449 +/- ##
===========================================
+ Coverage 86.43% 88.12% +1.68%
===========================================
Files 129 115 -14
Lines 5161 4310 -851
Branches 680 559 -121
===========================================
- Hits 4461 3798 -663
+ Misses 521 364 -157
+ Partials 179 148 -31
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
davidlougheed
requested changes
Oct 24, 2023
...d_metadata_service/patients/migrations/0005_remove_individual_comorbid_condition_and_more.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of the MCode app needs to be performed in a two steps process.
First, we need to remove all references to MCode from the other applications, which entails performing the data migrations in our instances (individual mcode fields) to remove the models without losing data.
Finally, when all our instances have been migrated according to the first step, we can completely remove the "mcode" application directory from katsu.
Step 1 requires the mcode migrations (
/chord_metadata_service/mcode/migrations), which is why we can't remove the "mcode" directory right away in step 1.This PR and its release are the first step in this process.